bpo-36106: resolve sinpi name clash with libm (IEEE-754 violation)#12027
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
See https://bugs.python.org/issue36106 for the bug report. |
the standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4)
dimpase
changed the title
|
I put a comment on bpo. |
I have done it, just takes a while to get through... |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
serhiy-storchaka
added
type-bug
Co-Authored-By: dimpase <dimpase@gmail.com>
|
A backport to 2.7 would be great, too. |
|
Thanks @dimpase for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7. |
…ythonGH-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Dima Pasechnik <dimpase@gmail.com>
|
GH-12046 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @dimpase and @serhiy-storchaka, I could not cleanly backport this to |
|
Signing the CLA is not necessary for trivial changes. |
|
Thank you for your contribution @dimpase! Unfortunately, our bot failed to backport this change to 2.7 automatically. Do you mind to backport it manually, if this is needed? |
…H-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Dima Pasechnik <dimpase@gmail.com>
|
For reference, we (FreeBSD) are tracking this downstream |
OK, sure. The problem is in unrelated to this patch changes to the file in question, which confuse cherry_picker. Working on it. |
according to https://check-python-cla.herokuapp.com/ I've signed the CLA - it's probably not automatically updated... |
the standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worked on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4) https://bugs.python.org/issue36106 this is a backport of python#12027 to 2.7 branch.
|
GH-12050 is a backport of this pull request to the 2.7 branch. |
…on). (GH-12027) (GH-12050) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worked on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4).
bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (pythonGH-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Victor Stinner <vstinner@python.org>
bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (pythonGH-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Victor Stinner <vstinner@python.org>
bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (pythonGH-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Victor Stinner <vstinner@python.org>
bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (pythonGH-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Victor Stinner <vstinner@python.org>
bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (pythonGH-12027) The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4). (cherry picked from commit f57cd82) Co-authored-by: Victor Stinner <vstinner@python.org>
7 participants
the standard math library (libm) may follow IEEE-754 recommendation to
include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x).
And this triggers a name clash, found by FreeBSD developer
Steve Kargl, who worken on putting sinpi into libm used on FreeBSD
(it has to be named "sinpi", not "sinPi", cf. e.g.
https://en.cppreference.com/w/c/experimental/fpext4)
https://bugs.python.org/issue36106